Description

fixes #651
This PR fixes a critical AST validation crash that occurs when using Concerto v4 engine (specifically 4.0.0-beta.1 and later) alongside markdown-transform. I uncovered this bug 2-3 weeks ago and and the fix was easier than I anticipated!

The Root Cause:
As described in the issue:
In packages/markdown-common/lib/FromMarkdownIt.js (blockToCommonMark), the parser was explicitly deleting the nodes array if a markdown element (like an empty clause, list, or blockquote) had no children. While Concerto v3 permitted this "lazy AST" where the array was simply undefined, the new strict type-checking in Concerto v4 throws a fatal ValidationException: Expected property 'nodes' to be an array because nodes is defined as a mandatory array in the metamodel.

The Fix:
Removed the aggressive deletion block (delete node.nodes) in FromMarkdownIt.js so that empty elements correctly retain an empty array ("nodes": []).

Testing / Validation

• Tested against Concerto v3: Fully backward compatible. Ran the full test suite and updated Jest snapshots successfully.
• Tested against Concerto v4: Prevents the ValidationException crash in strict parsing environments.

Standalone Script Output Proof:
I made a script to directly test this:
By feeding an empty clause ({{#clause testClause}}\n{{/clause}}) into CiceroMarkTransformer, we can see the exact structural change to the AST:

Before (Fails v4 Validation):

--- RAW AST OUTPUT ---
{
  "$class": "org.accordproject.ciceromark@0.6.0.Clause",
  "name": "testClause"
}
❌ BUG REPRODUCED: 'nodes' array was deleted!

After (Passes v4 Validation):

--- RAW AST OUTPUT ---
{
  "$class": "org.accordproject.ciceromark@0.6.0.Clause",
  "name": "testClause",
  "nodes": []
}
✅ FIX WORKS: 'nodes' array is present!